Add removal reason to EntityRemoveFromWorldEvent #11779
Conversation
|
Tests fail, you might have to update it to check for our event cause instead. you can also now remove the // Paper comments inside of source files, and for those lines that had a CB comment only from adding the event cause, you can replace their comment with ours |
TonytheMacaroni
force-pushed
the
removal-reason
branch
2 times, most recently
from
e203dd4 to
9092ebb
Compare
|
Re-added the missing test file diff; seems I missed it when updating the PR. Modified the comments. Also moved the usage of |
TonytheMacaroni
force-pushed
the
removal-reason
branch
from
9092ebb to
174e25e
Compare
kennytv
added
the
priority: high
There was a problem hiding this comment.
For the Cause enum, I think the 2 booleans should be removed and just be made booleans on the event itself. I don't like tying those to the removal reason. What if a removal reason can be used in 2 places where those values should be different. I don't see much benefit tying them together instead of just putting them on the event itself.
Supercedes #10149.